search

sudodoki / copy-button

Web component to copy target text/dom-node value to clipboard
http://sudodoki.github.io/copy-button/example
19 stars 15 forks source link

Upgrade to Custom Elements v1 #5

Open shvaikalesh opened 8 years ago

shvaikalesh commented 8 years ago

Sadly, we should also change API from <copy-button> to <button is=copy-button> for better accessibility, semantics, and standards compliance. Also, we should use slot instead of target-element attribute.

EDIT: changed my mind (Also the future of is is not clear). <copy-button> stays, but attributes should be deprecated in favor of slots.

amitaibu commented 7 years ago

we should use slot instead of target-element attribute.

Do you mean there's currently a way to do it, or it needs work?

shvaikalesh commented 7 years ago

It needs work.

wazzzzza commented 6 years ago

Hi did you manage to allow adding custom classes to the button as requested here?