search

sudomesh / LoRaLayer2

Layer 2 routing protocol for LoRa connected devices
86 stars 29 forks source link

LoRaLayer2 shouldn't refer to "WebSockets" #3

Closed tlrobinson closed 4 years ago

tlrobinson commented 4 years ago

It seems like this library shouldn't specifically refer to "WebSockets" even thought that's how disaster-radio currently uses it, i.e. this change: https://github.com/sudomesh/LoRaLayer2/commit/2f6ecd1b0f8d97aae9d8bc964a12b9f452d18c7f although I agree _chatBuffer wasn't a great name either.

I think a more generic name like _messageBuffer would be appropriate.

paidforby commented 4 years ago

Agreed. chatBuffer was a bad name. That's why I changed it. wsBuffer isn't an ideal name either. I think I considered messageBuffer, but I have so many local variables called "message". Really, I just need to go through and decide what parts are called what. Like when is piece of data a packet and when is it a message. And what buffer handles what data. Of course, it should be as generic as possible, since websocket is not the only option for an upper-layer.

paidforby commented 4 years ago

Latest commit address this issue. I've renamed the buffers to be more descriptive, outBuffer is now L1OutBuffer inBuffer is now L1InBuffer wsBuffer is now L3OutBuffer

There is still no L3InBuffer, because I have yet to come across as need, though I could imagine it being useful if there are multiple users on the same node.

If you think this is an adequate solution to your issue, feel free to close.