search

sudomesh / disaster-radio

A (paused) work-in-progress long-range, low-bandwidth wireless disaster recovery mesh network powered by the sun.
https://disaster.radio
1.06k stars 107 forks source link

printRoutingTable() function is not public #32

Closed matthewrwright closed 4 years ago

matthewrwright commented 4 years ago

Not sure whether to raise this as a disaster-radio issue or a LoRaLayer2 issue - apologies if I've pushed it in the wrong place.

On make:

In file included from ./firmware/esp32_ttgo/console.cpp:2:0: ./libs/LoRaLayer2/src/LoRaLayer2.h: In member function 'void consoleClass::lr(char (*)[8])': ./libs/LoRaLayer2/src/LoRaLayer2.h:74:10: error: 'void LL2Class::printRoutingTable()' is private void printRoutingTable(); ^ ./firmware/esp32_ttgo/console.cpp:21:31: error: within this context LL2.printRoutingTable(); ^ make: *** [Makefile:262: /tmp/mkESP/main_ttgo-lora32-v1/console.cpp.o] Error 1

Resolved by moving the definition in libs/LoRaLayer2/src/LoRaLayer2.h from private to public.

paidforby commented 4 years ago

Good catch! This really an issue with LoRaLayer2, this is an OK place to inquire about it though. Looks like I made some local changes that library that I never pushed to the repo. I pushed those changes here and updated fetch_deps to checkout the latest. Make sure you always pull the latest LoRaLayer2, since I'm actively making changes to that repo. Likewise, I'll make sure to always push any necessary updates to the libraries being used.