Don't swallow errors in makenode.js - Githubissues

sudomesh / makenode

Configures new sudo mesh nodes

8 stars 8 forks source link

Don't swallow errors in makenode.js #31

Open gobengo opened 6 years ago

gobengo commented 6 years ago

Today @squeeesh and @eenblam and I were setting up an n600. We got a cryptic-ish error from makenode and had to look into the code to diagnose.

There are two things this PR does to make it easier to triage errors in the future

Fix a couple places in async functions where the error object wasn't getting passed to callback
Don't pass strings to error callbacks. Strings don't have useful stack traces. Error objects do.

bennlich commented 6 years ago

:+1: