One bad 'node' from /nodes API (and db) - Githubissues

sudomesh / monitor

a way to monitor health of (people's open) network

GNU General Public License v3.0

5 stars 7 forks source link

One bad 'node' from /nodes API (and db) #10

Closed gobengo closed 6 years ago

gobengo commented 6 years ago

https://peoplesopen.herokuapp.com/api/v0/nodes

Scroll down and/or look at the last one

{
timestamp: "2018-05-08T22:23:10.022Z",
nodeIP: ""
}

Actual: There is a node with nodeIP of empty string and no gatewayIP. Expected: All nodes in this array have a truthy nodeIP and gatewayIP.

Other info

I believe the bad data is in the JSON string in memcache
I think this is due to faulty parsing in the /route-table endpoint.

I think I can fix it. Putting here to track.

bennlich commented 6 years ago

I got the urge :-P