Clean cruft from original application

sudomesh / monitor

a way to monitor health of (people's open) network

GNU General Public License v3.0

5 stars 7 forks source link

Clean cruft from original application #5

Closed eenblam closed 6 years ago

eenblam commented 6 years ago

Can we decruft some stuff from the old application, while also doing a better job of attributing it?

For example:

[ ] I'm not sure how legit it is to distribute under GPL when app.js is MIT.
[x] ~Is bin/ cruft? Can we get rid of it (and the dependency on debug) in favor of heroku local www?~ Nevermind
[x] Remove "Memcachier" stuff (fixed by 2e3f35fa55bbab282bb701216072df770e892e92)

More to come, maybe?

bennlich commented 6 years ago

bin/ is referenced here: https://github.com/sudomesh/monitor/blob/master/Procfile, which is read by foreman, I believe.

eenblam commented 6 years ago

Yeah, spent the evening getting a better handle on how things are laid out.

bin/ makes sense, and I didn't look hard enough at debug to realize it's actually just a logger. I'm too used to coming across Flask apps with debug mode enabled.

eenblam commented 6 years ago

This issue was quickly resolved; apologies for leaving it open.