curl missing from auto-build firmware

sudomesh / sudowrt-firmware

Scripts to build the sudo mesh OpenWRT firmware.

Other

73 stars 19 forks source link

curl missing from auto-build firmware #150

Closed Juul closed 5 years ago

Juul commented 6 years ago

The curl package isn't installed on the mynet n600 image I got from https://builds.sudomesh.org/sudowrt-firmware/latest/

This makes autoconf not working.

Juul commented 6 years ago

@paidforby any ideas?

eenblam commented 6 years ago

Oh, weird! I noticed this in my own builds - see #145. I didn't realize it wasn't just mine, so I thought my builds were broken somehow.

EDIT: This is also what was blocking me from testing #140.

paidforby commented 6 years ago

weird, curl is definitely listed in packages. i would start by running the rebuild locally with debugging enabled by adding V=s option to make in this line in build_lib, https://github.com/sudomesh/sudowrt-firmware/blob/master/build_lib#L346 and check what happens when it tries to install curl. Maybe something changed with the curl package for openwrt? I don't have an N600 on hand to test with, can try reproducing later this week.

paidforby commented 6 years ago

few things I notice after running a fresh build (not a rebuild),

We are installing both libcurl and curl. Wonder if there's conflict? Or what's the difference?
The curl is found in 2 or 3 locations, feeds/oldpackages/package/network/utils/curl feeds/openwrt/lang/perl-www-curl feeds/wlanslovenija/net/curl What's the difference? Which, if any, are getting installed?
Is this just an issue when "rebuilding" or is it an issue on first build also?

paidforby commented 5 years ago

Notes regarding test builds I ran today,

fresh build of firmware in a new docker container, resulting binary does have curl installed.
create a new container from the image generated by the fresh build, re-run make using build_only as entrypoiny, which calls openwrt_rebuilder function from build_lib, new binary does not have curl installed.
create a new container from the image generated by the fresh build, re-run make using build_pre as entrypoint, which reruns the full build in the same way as a fresh builds, new binary does have curl installed! The build still only took a few minutes to complete, just like the rebuilder.

This third attempt appears to be the solution, I'm guessing the rebuilder function was missing some crucial configurations that prevented some packages from being installed.

paidforby commented 5 years ago

cool, the images stored at http://builds.sudomesh.org/sudowrt-firmware/latest/ar71xx/ now have curl installed. There also appeared to be an issue with the docker hub image (maybe because I had ran the rebuilder once it in?) so I uploaded a fresh image that I knew was clean. I encourage @bennlich or @Juul to try flashing a node with latest, autoconf should now work, gonna close this issue for now.