sudoroom / sudo-humans

hackerspace membership server
Other
37 stars 19 forks source link

Adds npm to the list of packages to install. #28

Closed rcsheets closed 8 years ago

rcsheets commented 9 years ago

I was getting started looking at sudo-humans and noticed that npm doesn't get installed automatically with nodejs, but it's required to follow the instructions in the readme. So I figured I'd improve the readme a little.

ghost commented 9 years ago

npm is bundled with node, so when you install node you get npm too.

rcsheets commented 9 years ago

It's a separate package and the nodejs package does not depend on npm.

rcsheets commented 9 years ago

The reverse dependency relationship does exist, so the readme could be adjusted to only call for the installation of npm, allowing nodejs to be pulled in automatically.

ghost commented 9 years ago

It's a separate package in debian, but they're bundled on nodejs.org. The version in debian is very out of date and defines the node binary as nodejs, so it's not great to use anyway.

rcsheets commented 9 years ago

The readme suggests using node 0.10.21 and a /usr/local/bin/node symlink to fix the binary name issue. The version from debian is 0.10.29.

If the readme is totally wrong, then this PR is certainly no good, but only because the readme needs even more changes.

I started from the assumption that the readme was basically correct, but simply missing any mention of the required npm package. Should the readme be changed to advise installing a newer version of node from nodejs.org, avoiding the debian package entirely?

yardenac commented 8 years ago

I'm merging this because even if they're bundled on nodejs.org, specifying npm may help someone and harms no one.