search

sudoroom / sudo-humans

hackerspace membership server
Other
37 stars 19 forks source link

node version #63

Open okdistribute opened 8 years ago

okdistribute commented 8 years ago

does this require 0.12 or would it be easy enough to update deps so that it works with >=4.0.0? @substack

morganrallen commented 7 years ago

level has been updated, it's the only module that prevented building on Node 7.6.0

rcsheets commented 7 years ago

I'd feel more confident about a node upgrade (and large changes generally) if we had a test suite.

kenrestivo commented 3 years ago

I added a github workflow for testing against modern nodejs, and, as expected, it did not go well https://github.com/kenrestivo/sudo-humans/actions/runs/728392688

okdistribute commented 3 years ago

Change npm ci to npm install in your github action script and you'll get better progress. This app doesn't have a package-lock.json or shrinkwrap.json (this is what I gleaned from the debug output from github actions.)

chughes87 commented 3 years ago

https://github.com/kenrestivo/sudo-humans/pull/17/files