search

suds-community / suds

Suds is a lightweight SOAP python client for consuming Web Services. A community fork of the jurko fork.
https://suds.readthedocs.io/
GNU Lesser General Public License v3.0
173 stars 56 forks source link

Allow use of empty string as a value for a Attribute #108

Closed martin-pil closed 1 month ago

martin-pil commented 2 months ago

As talked about in https://github.com/suds-community/suds/issues/107

No tests are affected by this change, all tests ran fine locally.

phillbaker commented 2 months ago

Thanks for the PR, please add a test that covers this behavior.

On Thu, Sep 12, 2024 at 2:01 AM Martin Pilros @.***> wrote:

As talked about in #107 https://github.com/suds-community/suds/issues/107

No tests are affected by this change, all tests ran fine locally.

You can view, comment on, or merge this pull request online at:

https://github.com/suds-community/suds/pull/108 Commit Summary

File Changes

(1 file https://github.com/suds-community/suds/pull/108/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/suds-community/suds/pull/108, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAXCKNTJQHGLJLIDYOOLOTZWEU5NAVCNFSM6AAAAABOCM3OMCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGUZDCNBSGY4DCNA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

martin-pil commented 2 months ago

After looking into "tostr" simplified the code a bit, but I would say that the check must have been used to block empty strings as tostr will always return a string. Hope that this is still something that can be added to suds.