Closed martin-pil closed 1 month ago
Thanks for the PR, please add a test that covers this behavior.
On Thu, Sep 12, 2024 at 2:01 AM Martin Pilros @.***> wrote:
As talked about in #107 https://github.com/suds-community/suds/issues/107
No tests are affected by this change, all tests ran fine locally.
You can view, comment on, or merge this pull request online at:
https://github.com/suds-community/suds/pull/108 Commit Summary
- 2975319 https://github.com/suds-community/suds/pull/108/commits/2975319847310be1d89d2ec44da373d6fe7af746 Allow use of empty string as a value for a Attribute
File Changes
(1 file https://github.com/suds-community/suds/pull/108/files)
- M suds/mx/appender.py https://github.com/suds-community/suds/pull/108/files#diff-369ac5db3035c5f356609da230d9b8cac2acc921bbea752a19e2fbdb76bbbece (4)
Patch Links:
- https://github.com/suds-community/suds/pull/108.patch
- https://github.com/suds-community/suds/pull/108.diff
— Reply to this email directly, view it on GitHub https://github.com/suds-community/suds/pull/108, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAXCKNTJQHGLJLIDYOOLOTZWEU5NAVCNFSM6AAAAABOCM3OMCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGUZDCNBSGY4DCNA . You are receiving this because you are subscribed to this thread.Message ID: @.***>
After looking into "tostr" simplified the code a bit, but I would say that the check must have been used to block empty strings as tostr will always return a string. Hope that this is still something that can be added to suds.
As talked about in https://github.com/suds-community/suds/issues/107
No tests are affected by this change, all tests ran fine locally.