search

suds-community / suds

Suds is a lightweight SOAP python client for consuming Web Services. A community fork of the jurko fork.
https://suds.readthedocs.io/
GNU Lesser General Public License v3.0
173 stars 56 forks source link

Support process SOAP 1.2 reply #96

Closed eshizhan closed 8 months ago

phillbaker commented 11 months ago

Thanks for the contribution. Can you please add a test covering this behavior?

On Sat, Dec 23, 2023 at 11:38 AM eshizhan @.***> wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/suds-community/suds/pull/96 Commit Summary

File Changes

(1 file https://github.com/suds-community/suds/pull/96/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/suds-community/suds/pull/96, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAXCKKRCW5FRDFABZP3PXLYK4CHBAVCNFSM6AAAAABBA4YSFOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA2TIOBTG44DSMI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

eshizhan commented 11 months ago

@phillbaker add test case, thx for review!

phillbaker commented 11 months ago

Hi, it looks like the test suite is failing on CI. Can you take a look at the failing tests?

On Sun, Dec 24, 2023 at 10:10 PM eshizhan @.***> wrote:

@phillbaker https://github.com/phillbaker add test case, thx for review!

— Reply to this email directly, view it on GitHub https://github.com/suds-community/suds/pull/96#issuecomment-1868691865, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAXCKN7ICAE2OLWEACHB6DYLDVDDAVCNFSM6AAAAABBA4YSFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRYGY4TCOBWGU . You are receiving this because you were mentioned.Message ID: @.***>

eshizhan commented 11 months ago

I saw it, but these failures have nothing to do with this PR. I think these failures seem to be related to pytest in the CI environment.

eshizhan commented 11 months ago

The reason is 3.x bump to 3.12, it's remove distutils module.

phillbaker commented 10 months ago

Thanks, I’ll check it out.

On Mon, Dec 25, 2023 at 9:47 AM eshizhan @.***> wrote:

The reason is 3.x bump to 3.12, it's remove distutils module.

— Reply to this email directly, view it on GitHub https://github.com/suds-community/suds/pull/96#issuecomment-1869014026, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAXCKLDB77MFC254MYZJ4TYLGGXVAVCNFSM6AAAAABBA4YSFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRZGAYTIMBSGY . You are receiving this because you were mentioned.Message ID: @.***>

phillbaker commented 10 months ago

Sorry for the slow update here, fixes have been merged to master to fix python 3.12, can you rebase your branch please?