search

sudz123 / happy_hacking

Let's have a productive Hacktoberfest
MIT License
47 stars 330 forks source link

[bug] style overrides #545

Open vinnyA3 opened 5 years ago

vinnyA3 commented 5 years ago

Description:

The current stylesheet import order is causing style overrides. For example: the bootstrap stylesheet is overriding the the font styling in stylesheet styles1.css.

Solution:

Reorganize the stylesheet import order as such:

<!--Scripts for Carousel-->
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css"/>
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/fontawesome/4.7.0/css/font-awesome.min.css"/>
<link rel="stylesheet" href="style/home/styles1.css" />
<link rel="stylesheet" id="home-styles" href="style/home/home.css" type="text/css" media="all" />

The re-ordering would apply the original styles1.css author's intended font for both headers and paragraph elements. The outcome would appear as follows:

before style import re-order: before-font-change

after style import re-order: font-diff

@sudz123 If this change is too drastic, the best option, in my opinion, would be to remove the font-styling in styles1.css (so bootstrap's font gets inherited). I can always open a pull request with the changes upon request, or if someone else would like, they can do so as well.

guido97 commented 5 years ago

fix the override in pull request #590