Closed tenten0213 closed 9 years ago
It is nice idea!
It seams that Redmine will crash if @issue.assigned_to
is nil
.
I would like you to add a sentence to check nil
at RedmineWebhook::AuthorWrapper#to_hash
.
It should return {}
if its @author
is nil
.
For example, as follows:
def to_hash
return nil unless @author
...
It seams that Redmine will crash if @issue.assigned_to is nil. I would like you to add a sentence to check nil at RedmineWebhook::AuthorWrapper#to_hash. It should return {} if its @author is nil.
I fixed it. It return "assignee": null
if not set assignee.
{
"payload": {
"issue": {
"author": {
...
},
"assignee": null,
...
LGTM. returning nil is right. Thanks a lot.
becomes able to get the 'Assignee' data after merge this PR.