search

suer / redmine_webhook

147 stars 81 forks source link

IssueWrapper: Add custom field values #22

Closed corthmann closed 5 years ago

corthmann commented 5 years ago

Hi @suer ,

I needed to have a bot respond to Redmine tickets based upon custom fields. In order to achieve added custom_field_values to the webhook payload through theIssueWrapper.

I also added the missing source definition in the Gemfile.

Perhaps this would be useful to others as well?

suer commented 5 years ago

It is good, so I want to merge this PR.

I have a question. Is source necessary?

In Redmine, plugin's Gemfile are evaluated in original Gemfile. https://github.com/redmine/redmine/blob/master/Gemfile#L95

So I think that plugin's Gemfile need not source definition.

corthmann commented 5 years ago

I added source because running bundle install in this repository failed. I had not checked how Redmine loads the plugin Gemfiles - I think you are right that in that context you do not need source.

I will revert the Gemfile change for you. 😃

suer commented 5 years ago

Thank you for your contribution!