Fixes and merges from other repos - Githubissues

suer / redmine_webhook

148 stars 81 forks source link

Closed serpi90 closed 4 years ago

serpi90 commented 4 years ago

Changes:

fix: handle empty webhook url
- I cant recall if i wrote or if it was cherry picked from another fork.
feature: emit webhook for bulk edit or fetch changeset
- Make webhooks compatible with the controller_issues_bulk_edit_after_save patch: Redmine issue #8757
- Taken from AdmanTIC/redmine_webhook@971640c8fb2e70aa204047f1639a89758e14d439
feature: Add default webhook configuration if absent from project
- Taken from AdmanTIC/redmine_webhook@971640c8fb2e70aa204047f1639a89758e14d439
- No UI for this, save a webhook with a project_id of 0 in the database.

suer commented 4 years ago

The link in the description seems to be part of the change. Are all commits necessary?

I can not determine those changes are correct. I'm glad if you write detail description.

serpi90 commented 4 years ago

Updated the issue description with a detail of the changes

serpi90 commented 4 years ago

The reference is the current commit of AdmanTIC's master branch from that repository, where i took the commits from.

serpi90 commented 4 years ago

Sorry for not answering earlier. I'm not using that particular hook, based on your comment I would be inclined to removing it.

suer commented 4 years ago

I'm glad your comment!

If you do not use model_changeset_scan_commit_for_issue_ids_pre_issue_update, I want to remove it.

Do you want to make Pull Request to remove it? Or I can do it.

serpi90 commented 4 years ago

If you don't mind waiting a couple days, I can do it

suer commented 4 years ago

It sounds good for me. I don't mind waitng. I'm looking forward to your pull request.