search

suer / redmine_webhook

147 stars 81 forks source link

Support redmine 3.0 #7

Closed miurahr closed 9 years ago

miurahr commented 9 years ago

It get mass-assignment protection error with redmine 3.0.x It is because rails 4 use strong parameters. This fix mass-assignment protection error for protected project_id attribute.

Signed-off-by: Hiroshi Miura miurahr@linux.com

miurahr commented 9 years ago

It fixes following error and make it work on redmine 3.0.1

WARNING: Can't mass-assign protected attributes for Webhook: project_id
    app/views/common/_tabs.html.erb:22:in `block in _app_views_common__tabs_html_erb__2143282081429384927_70762940'
    app/views/common/_tabs.html.erb:21:in `each'
    app/views/common/_tabs.html.erb:21:in `_app_views_common__tabs_html_erb__2143282081429384927_70762940'
    app/helpers/application_helper.rb:321:in `render_tabs'
    app/views/projects/settings.html.erb:3:in `_app_views_projects_settings_html_erb__2938167809286768750_70776620'
  Rendered plugins/redmine_webhook/app/views/webhook_settings/_show.html.erb (20.9ms)
suer commented 9 years ago

LGTM. Thanks!