search

suever / pydicom-experimental

pydicom test
0 stars 1 forks source link

dataset.get() should return consistent results when called with a tag or with a string #134

Open suever opened 9 years ago

suever commented 9 years ago

From francesc...@gmail.com on September 16, 2013 06:14:47

What steps will reproduce the problem? 1. dataset.get("DicomString") returns a value

  1. dataset.get(Tag(0xABCD,0x0000)) returns a DataElement, whose value is the same as the value above

I think the behavior should be made consistent, and either return a DataElement or a value in both cases.

Original issue: http://code.google.com/p/pydicom/issues/detail?id=134

suever commented 9 years ago

From darcymason@gmail.com on September 18, 2013 08:56:35

It's an interesting thought ... but the current behaviour is in line with what happens if you do: dataset.DicomString vs. dataset[Tag(...)]. I don't remember whether get() was deliberately modelled after that or whether it just fell out of the coding that way. Will keep the issue alive and think about this.

Thanks Darcy

Status: Accepted