search

suever / pydicom-experimental

pydicom test
0 stars 1 forks source link

No force parameter in contrib.pydicom_series.read_files #146

Closed suever closed 9 years ago

suever commented 9 years ago

From nilgoye...@gmail.com on May 09, 2014 09:15:03

The problem is simple enough. On the last version of pydicom, 0.9.8, there's no way to use the "force" parameter in read_files. It seems like a bug to me because you can use it with read_file.

d = dicom.read_file('~/path/im.dcm', force=True) # Works series = read_files('~/path', force=True) # No "force" parameter

I believe this change won't break anything for other users if we default force to False.

I already cloned the repo on my computer and done the required change. I just need to understand how code.google.com works to submit a patch :) I'll update this issue with a clone soon.

Original issue: http://code.google.com/p/pydicom/issues/detail?id=146

suever commented 9 years ago

From nilgoye...@gmail.com on May 09, 2014 06:52:39

I cloned and pushed a fix there https://code.google.com/r/nilgoyette-pydicom-force/ The fix is really simple, I just add the parameter to read_files and pass it to read_file.

suever commented 9 years ago

From darcymason@gmail.com on May 12, 2014 15:13:00

Closed by revision 591e350da859

Status: Verified