suever
commented
9 years ago From almar.klein@gmail.com on February 16, 2010 03:22:56
After examining the source code, I see that a missing header is assumed when the "DICM" string is not found. I don't know whether this occurs often, but strictly speaking, such a file is not valid dicom, and IMO should not be processed.
In my application, I use CT data, which is stored in several hundred dicom files in a directory. Sometimes there may be a text file or xml file with a summary of the data of some sort. I could of course test for the extension, but catching a NotValidDicom exception (or something like that) would be more beautiful (and would make my application work whatever extra data I'd like to put with the dicom files).
I'd be happy to submit a patch if you agree with me.
From almar.klein@gmail.com on February 16, 2010 06:14:19
What steps will reproduce the problem? Try to read a file that is not a dicom file. What is the expected output? What do you see instead? I would expect an Exception being thrown telling me the file is not dicom. The read-function could easily check this by looking for "DICM" at position 128 in the file. Instead, a Memory error is produced. What version of the product are you using? 0.9.4
Original issue: http://code.google.com/p/pydicom/issues/detail?id=75