search

suever / pydicom-experimental

pydicom test
0 stars 1 forks source link

Cannot create DicomIter on files with Explicit VR Transfer Syntax UID #82

Closed suever closed 9 years ago

suever commented 9 years ago

From l...@unistra.fr on March 08, 2010 06:17:59

What steps will reproduce the problem? iterator = dicom.filereader.DicomIter(file)

What is the expected output?

Iterator is created

What do you see instead?

File "/usr/lib/python2.6/dist-packages/dicom/filereader.py", line 112, in init logger.debug("Using %s VR, %s Endian transfer syntax" %(("Explicit", "Implicit")[is_implicit_VR], ("Big", "Little")[is_little_endian]))

What version of the product are you using? 0.9.4-1 / Linux

The code in DicomIter.init sets either is_explicit_VR or is_implicit_VR, but the call to logger.debug is only based on is_implicit_VR. This can be fixed by getting rid of the is_explicit_VR variable. I guess the same proble will happen with Big Endian transfer syntax.

Original issue: http://code.google.com/p/pydicom/issues/detail?id=82

suever commented 9 years ago

From l...@unistra.fr on March 08, 2010 05:49:03

Fixed in personal clone : https://code.google.com/r/lamy-pydicom/source/detail?r=92fc0ef56eb083840a54b07c05659faac48cc4a9

suever commented 9 years ago

From darcymason@gmail.com on March 08, 2010 18:37:02

Thanks for this -- I thought all references to is_explicit_VR had been converted, but apparently not. I'll fold this in soon and push to the main repository.

Status: Accepted
Labels: -Priority-Medium Priority-High Milestone-NextRelease

suever commented 9 years ago

From darcymason@gmail.com on April 13, 2010 18:42:24

This issue was closed by revision 14894de0a4 .

Status: Fixed