sufendyc / battleships

Open platform for developing and fighting bots.

2 stars 2 forks source link

Dev 16 bootstrap migration #22

Closed ethanckw closed 10 years ago

ethanckw commented 10 years ago

16

Change templates to use template inheritance through base.html
Implement Nav Bar across site
Migrate the following elements to bootstrap. Buttons, Grid, Table, Form

jhibberd commented 10 years ago

@lukeashworth can you evaluate this pull request and let me know if you have any objections

lukeashworth commented 10 years ago

@jhibberd @ethanckw

I'll have a look today/tomorrow and get back to you both.

sufendyc commented 10 years ago

I had a quick test. Liking the top navigation bar :) Found a tiny bug in the games page, though. The Leaderboard button link leads to Help page instead of the leaderboard page.

ethanckw commented 10 years ago

Cool, i've fixed it and resolved the conflicts with origin/master.

jhibberd commented 10 years ago

Looks good but I when I try and visualise a bot that has an error (bad syntax, illegal move, etc.) nothing happens. The current version displays a big red box with details of the error message. I can't see any error messages in the JavaScript console to indicate what's going wrong.

ethanckw commented 10 years ago

Fixed the javascript to show error notification.

jhibberd commented 10 years ago

I made the following minor improvements following the merge of this pull request:

formatted average time to 2 decimal places
removed references to Pure CSS framework
ordered player bots so most recent is first
only show upload form if viewing current user's player page

https://github.com/jhibberd/battleships/commit/06f11f6caabca0aac81f2e29d66484fbc7a8bc41