Issue #15 - Kept multiple whitespace in embedded params using gsub only on query template. - Githubissues

sufleR / sql_query

Ruby gem to load SQL queries from `.sql.erb` templates using ERB.

MIT License

159 stars 15 forks source link

Issue #15 - Kept multiple whitespace in embedded params using gsub only on query template. #17

Closed Barbez95 closed 1 year ago

Barbez95 commented 1 year ago

Updated travis.yml to Ruby 2.6.0 to avoid bundler install error.

Barbez95 commented 1 year ago

Hi @sufleR ! I'm totally new to pull-requests on Github and Travis CI, so I hope I haven't done some silly mistakes!

About the fix: in order to keep a similar logic to current version, I've isolated the read logic of query template file and applied gsub only on the template content (before params get embedded).
About specs: in order to test them into Travis CI, I had to update Ruby version due to a bundler install error (it requires at least Ruby 2.6.0). I've added a simple spec which includes the case of a embedded params with multiple whitespaces.

Let me know what do you think about the changes! Thanks