sugar-cat7 / vspo-portal

WIP すぽじゅーる
https://vspo-schedule-sugar-cat7-s-team.vercel.app
MIT License
10 stars 3 forks source link

Fixed-text English i18n #424

Closed sruenwg closed 1 week ago

sruenwg commented 1 week ago

PR for adding fixed-text English strings to the web app, as part of #406.

This is currently a WIP. Just sharing my progress to confirm I'm not doing anything egregious.

Some sample screenshots of what's been done:

image image
vercel[bot] commented 1 week ago

@sruenwg is attempting to deploy a commit to the sugar-cat7's Team Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
vspo-schedule ✅ Ready (Inspect) Visit Preview Jun 29, 2024 9:16am
sugar-cat7 commented 1 week ago

@sruenwg I apologize, but the process I added to getStaticProps has caused a conflict. I would appreciate it if you could fix it as well. 🙇

sruenwg commented 1 week ago

@sugar-cat7 No worries 👍

I'm wondering where to go from here — I believe the remaining untranslated parts are:

  1. the site news contents,
  2. the about page contents, and
  3. the terms and privacy pages.

For 1 and 2, I can manually translate the content and store the English translations alongside the original Japanese files, if that's what we want to do.

For 3 though, I'm not very familiar with how these pages should be written. If you used some sort of generator for these, I wonder if it's possible to use it again to output an English version.

sugar-cat7 commented 1 week ago

@sruenwg Thank you very much for proceeding so quickly 🙇

I will handle the translation for contents 1 to 3 on my end! (The original Japanese content is outdated, so I will revise and translate it simultaneously...)

Therefore, the scope of this PR should mainly focus on handling the dynamic content (livestream, clip, event...) pages!! (They are probably almost complete?)

sruenwg commented 1 week ago

@sugar-cat7 Great, thanks for taking care of that 👍

They are probably almost complete?

Yes, I'd say it's complete now. I'll mark this PR as ready for review, but if anything bothers you please let me know and I'll gladly make any changes.