sugar-cat7 / vspo-portal

WIP γ™γ½γ˜γ‚…γƒΌγ‚‹
https://vspo-schedule-sugar-cat7-s-team.vercel.app
MIT License
12 stars 4 forks source link

πŸ“Ž Implementation Language Selector #536

Closed sugar-cat7 closed 1 month ago

sugar-cat7 commented 1 month ago
  1. Language Selector UI Implementation:

    • Implement a user interface component for selecting the desired locale. This selector should allow users to choose their preferred language, which will then be applied across the application.
  2. Language-Specific Display for /schedule/all:

    • When users access the /schedule/all endpoint, the page should be displayed in the language corresponding to the selected locale. The application should detect the chosen locale and render the page accordingly.
sugar-cat7 commented 1 month ago

The idea is to prioritize as follows:

Locale from the cookie Locale from the path Default locale

sruenwg commented 1 month ago

@sugar-cat7

The idea is to prioritize as follows:

Locale from the cookie Locale from the path Default locale

Sorry I just noticed you seemed to have wanted the cookie to have higher priority than the path. Was the implementation in #540 alright? I gave the path higher priority than the cookie since I thought it would be annoying if the user manually typed /en in the URL but was redirected to /ja since that was the cookie value they had stored.

sugar-cat7 commented 1 month ago

@sruenwg

I gave the path higher priority than the cookie since I thought it would be annoying if the user manually typed /en in the URL but was redirected to /ja since that was the cookie value they had stored.

I completely agree with you, so I think the current implementation is better! Thank you so much πŸ™