sugar-cat7 / vspo-portal

WIP すぽじゅーる
https://vspo-schedule-sugar-cat7-s-team.vercel.app
MIT License
12 stars 4 forks source link

fix(web): let event dates be timezone-independent #606

Closed sruenwg closed 3 weeks ago

sruenwg commented 3 weeks ago

Fixes half of #542.

This PR makes it so the displayed event dates are no longer dependent on user time zone. E.g. if an event has date 2024-11-11T00:00:00Z, the event is listed as being on 2024-11-11 in all time zones.

https://github.com/user-attachments/assets/9f214e31-3a10-42c2-bee1-b7b176d4f5c6

Regarding the rest of #542, I am unsure if we should apply the same change as above to site news items since, on second thought, I feel site news items do carry time information. E.g. if the Discord bot was released on 2023-09-05T00:00:00Z, from the perspective of a user in Los Angeles, it might make more sense to say that the bot was released on 2023-09-04. @sugar-cat7 Please let me know which you would prefer.

vercel[bot] commented 3 weeks ago

@sruenwg is attempting to deploy a commit to the sugar-cat7's Team Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
vspo-schedule ✅ Ready (Inspect) Visit Preview Nov 5, 2024 6:27am
sugar-cat7 commented 3 weeks ago

Regarding the rest of https://github.com/sugar-cat7/vspo-portal/issues/542, I am unsure if we should apply the same change as above to site news items since, on second thought, I feel site news items do carry time information.

@sruenwg Personally, I think it would be better for site news items not to depend on the user’s time zone either. Like events, we round the display to 00:00:00, so making it dependent on time zones may not be ideal.

sruenwg commented 3 weeks ago

@sruenwg Personally, I think it would be better for site news items not to depend on the user’s time zone either. Like events, we round the display to 00:00:00, so making it dependent on time zones may not be ideal.

Sounds good, will raise a separate PR for that.