search

sugar-framework / sugar

Modular web framework for Elixir
https://sugar-framework.github.io/
MIT License
430 stars 29 forks source link

fix certificate error #60

Closed NARKOZ closed 9 years ago

coveralls commented 9 years ago

Coverage Status

Coverage remained the same when pulling baa88fd6f8a1a5edba19686977edc1f1efc93b63 on NARKOZ:patch-1 into de7c2882eb22257b5f60162f73928ce07e23a3c7 on sugar-framework:master.

slogsdon commented 9 years ago

Thanks @NARKOZ! I'd love to merge this into master, but I have a couple problems with it as it stands at the moment.

  1. This kills HTTPS altogether. I originally pulled this into Sugar from another project that enforces using HTTPS at all times. I can see how that shouldn't be the case for Sugar, but it still should be an option (via an application environment variable) for developers, one that probably should default to enabled.
  2. By switching line 123 from HTTPS to HTTP, applications would attempt to run HTTP twice but will fail the second time.

If you can amend your commit to take care of those, I'd be glad to merge in this PR. Thanks again!

coveralls commented 9 years ago

Coverage Status

Coverage remained the same when pulling c0d295a6c217f83d1a0d35ced91457911b72673e on NARKOZ:patch-1 into de7c2882eb22257b5f60162f73928ce07e23a3c7 on sugar-framework:master.

NARKOZ commented 9 years ago

@slogsdon updated. Now it will respond to https only when configured.

slogsdon commented 9 years ago

awesome! thanks @NARKOZ!