search

sugar-framework / sugar

Modular web framework for Elixir
https://sugar-framework.github.io/
MIT License
430 stars 29 forks source link

Fixing parentheses #70

Closed ghost closed 9 years ago

ghost commented 9 years ago

Half of the code contains parentheses around functions' arguments, and it's a bit disturbing to constantly switch from a syntax to another. It shouldn't break anything.

slogsdon commented 9 years ago

:heart: This looks great and would probably bring us closer to the community accepted style guide. I'll review this tonight!

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 99.57% when pulling 1aafdca208118b41ae9e2cb79dca33762f12a063 on Annwenn:parentheses into 3c3874945b3e8cc96073aed01550b34861c01e8b on sugar-framework:master.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 99.57% when pulling 1aafdca208118b41ae9e2cb79dca33762f12a063 on Annwenn:parentheses into 3c3874945b3e8cc96073aed01550b34861c01e8b on sugar-framework:master.

ghost commented 9 years ago

Of course I might have skipped some lines :) (and I don't hide you that a CODESTYLE.md describing how should look like the internal Sugar code would be helpful (like, always use parentheses, never forget to add a @spec line…)

slogsdon commented 9 years ago

I'm probably going to move the code bit by bit to reflect niftyn8/elixir_style_guide as it seems more and more people are using it as a reference. Thanks @Annwenn for getting this going!