Update deps version - Githubissues

kination commented 7 years ago

There are some warnings which causing from old version of http_router. Test case clears well. Please look on.

YellowApple commented 7 years ago

It looks like Travis is choking due to being configured with old Elixir versions. We should probably consider dropping the test cases for these and adding new ones to match Plug's mix.exs (so Elixirs "1.2.3" and "1.3.something", plus "1.4.0"), unless there's some specific demand to support pre-1.2 Elixir versions.

I reckon we should also consider dropping Ecto as an explicit dependency; AFAIK, there's nothing particularly dependent on Ecto in Sugar itself (I mean, the ensure_authenticated plug was designed around it, but it should work perfectly fine with any old function that provides any old struct, and if needed I'd be happy to rework that to be more generic).

@slogsdon: thoughts?

slogsdon commented 7 years ago

That sounds good. We can convert the Exto dependency to be optional if necessary. I can correct the Travis config soon to get that sorted out.

On Wed, Jan 25, 2017 at 6:41 PM -0500, "Ryan S. Northrup" notifications@github.com wrote:

It looks like Travis is choking due to being configured with old Elixir versions. We should probably consider dropping the test cases for these and adding new ones to match Plug's mix.exs (so Elixirs "1.2.3" and "1.3.something", plus "1.4.0"), unless there's some specific demand to support pre-1.2 Elixir versions.

I reckon we should also consider dropping Ecto as an explicit dependency; AFAIK, there's nothing particularly dependent on Ecto in Sugar itself (I mean, the ensure_authenticated plug was designed around it, but it should work perfectly fine with any old function that provides any old struct, and if needed I'd be happy to rework that to be more generic).

@slogsdon: thoughts?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

kination commented 7 years ago

@slogsdon @YellowApple Thanks. It seems good to make Ecto as an explicit dependency to make project more modular.

kination commented 7 years ago

mix test seems work well on my laptop. Would it be problem of elixir version. If it is, is there a problem to change elixir target version in travis?

kination commented 7 years ago

@slogsdon @YellowApple If you are busy, would you mind I work on update of this case?

remove unused test case
dropping Ecto as an explicit dependency

Thanks.

YellowApple commented 7 years ago

Sorry. Yeah, go for it if you want to tackle it in this PR (else, I'll hack away at it sometime tomorrow).

kination commented 7 years ago

@YellowApple Oh thanks! I'll look on yours and see what I can do more.

coveralls commented 7 years ago

Coverage remained the same at 97.934% when pulling 8fdd77a91378dd1177ebe24808c6a5ae223a724c on djKooks:patch-deps into 99abb518360de6d8a4648c08838aab03a0039481 on sugar-framework:master.

coveralls commented 7 years ago

Coverage remained the same at 97.934% when pulling 8fdd77a91378dd1177ebe24808c6a5ae223a724c on djKooks:patch-deps into 99abb518360de6d8a4648c08838aab03a0039481 on sugar-framework:master.

coveralls commented 7 years ago

Coverage decreased (-0.2%) to 97.727% when pulling 5bdff7966a3c38367ea12ed88c5129e46ecaf080 on djKooks:patch-deps into 99abb518360de6d8a4648c08838aab03a0039481 on sugar-framework:master.

coveralls commented 7 years ago

Coverage decreased (-0.2%) to 97.727% when pulling ca7a5d536e5ed25b6590ac2e4f10a01776586b1b on djKooks:patch-deps into 99abb518360de6d8a4648c08838aab03a0039481 on sugar-framework:master.

coveralls commented 7 years ago

Coverage decreased (-0.2%) to 97.727% when pulling e0461cb2b1afe17e3ce8fd0d3bf0bf4c49d07889 on djKooks:patch-deps into 99abb518360de6d8a4648c08838aab03a0039481 on sugar-framework:master.

YellowApple commented 7 years ago

Gah; try to make Travis happy and you just annoy Coveralls ;)

Summarizing the changes I've pushed to the PR to reflect previous discussion:

Version bumped to 0.5.0
Ecto and Postgrex removed from dependencies
Ecto model generation removed from Sugar's mix tasks (TODO: consider reimplementing these in a more generic way to support common choices like Ecto, Mnesia, CouchDB, etc.; whether we want to do this in Sugar itself or in a separate project dedicated to models is worth further discussion)
Tests cleaned up per the above
Travis config updated to test newer Erlang/Elixir versions
Sugar.Config.get tweaked to only merge default options into keyword lists (since Keyword.merge in Elixir 1.4.0 is stricter re: which lists are eligible for merging); corresponding test cases updated as well

All tests currently passing on all supported versions of Elixir, and coverage drop is effectively insignificant AFAICT. Given the scope of this change, pinging @slogsdon for review and approval (or rejection, of course!) before I merge this in and publish to Hex.pm.

kination commented 7 years ago

Great~thanks.

YellowApple commented 7 years ago

Merged. Will push up to Hex.pm shortly.

YellowApple commented 7 years ago

Published. Thanks to @djKooks for the PR and @slogsdon for the review.

sugar-framework / sugar

Update deps version #91