Remove warnings in test

sugar-framework / sugar

Modular web framework for Elixir

https://sugar-framework.github.io/

MIT License

430 stars 29 forks source link

Remove warnings in test #92

Closed kination closed 7 years ago

kination commented 7 years ago

It's quite minor updates. I removed some warnings while running test related with piping into function call. I'm still newbee in elixir so I'll keep researching framework and fix some of minor issues until getting more use to it. Please look on and let me know if there is any problem.

coveralls commented 7 years ago

Coverage remained the same at 97.727% when pulling 947d03cd4e918ba2a6fbe09bff99c82ec681c011 on djKooks:test-warn into f08d23578518ff9a376edcad8ee48ac93c10344c on sugar-framework:master.

YellowApple commented 7 years ago

Damn; this was next on my list and you beat me to it :)

Looks great to me. Will merge, pending response to the quick feedback question on lib/mix/tasks/server.ex:25

coveralls commented 7 years ago

Coverage decreased (-0.4%) to 97.309% when pulling f39fa13e86fa0090bf5e45ff328067784e3fb769 on djKooks:test-warn into f08d23578518ff9a376edcad8ee48ac93c10344c on sugar-framework:master.

coveralls commented 7 years ago

Coverage decreased (-0.4%) to 97.309% when pulling 02a4b110cdda1dda94ef41a59775b70f5a5040c3 on djKooks:test-warn into f08d23578518ff9a376edcad8ee48ac93c10344c on sugar-framework:master.

YellowApple commented 7 years ago

On the other hand, it ain't a big deal (doesn't break anything or generate warnings), and is just a stylistic thing. Merged.

kination commented 7 years ago

@YellowApple Thanks! Still there are more warnings on test. You could work on it cause I couldn't find a reason yet =_=;;

YellowApple commented 7 years ago

Yeah, I believe most of them are coming from elixir_http_router. I'm investigating right now.