search

sugarlabs / JClic

JClic Sugar activity
GNU General Public License v3.0
0 stars 3 forks source link

Sync with upstream version #2

Open tony37 opened 7 years ago

tony37 commented 7 years ago

This repository shows several commits yet the version number is still 1.

vipulgupta2048 commented 6 years ago

@tony37 Would that really matter, what version an application is. If the development and maintenance are going at a fast pace or a major new feature has been released. Then a change of versions could be taken into account. Do provide more details on the same.

quozl commented 6 years ago

@vipulgupta2048 the problem is real, but the cause is not obvious.

Problem is that activity/activity.info shows v1, so if a bundle is made from this repository now, it will not be installed on a Sugar system that already has v1 from activities.sugarlabs.org.

Cause is that @ezequielpereira did add dependency missing warning feature but without releasing a new version.

I've checked by unpacking the bundle from activities.sugarlabs.org, and commit 51f60ecc96dbed7a7b9d8d5701b915f7eaa620a7 is identical to v1. So I have tagged it v1 and pushed the tag.

An activity maintainer, if you'd like to take that role, would fix the bugs and release a v2. That's what @tony37 is effectively suggesting by opening this issue. See Modifying Activities - Checklist Maintainer for what steps are needed.

Also, this activity is a wrapper around an upstream project, and there's a new version upstream, so it would be sensible to merge that too.

rhl-bthr commented 5 years ago