search

sugarlabs / Pippy

Pippy allows the student to examine, execute, and modify simple Python programs. In addition it is possible to write Python statements to play sounds, calculate expressions, or make simple text based interactive games.
GNU General Public License v2.0
11 stars 34 forks source link

For consistency, eraser icon should only clear canvas #44

Closed icarito closed 7 years ago

icarito commented 7 years ago

It's a really scary functionality.

quozl commented 7 years ago

Ctrl+Z undo works to reverse any eraser button click. It is also in the scissors menu. Isn't that discoverable enough? I see undo only works before Ctrl+Q though.

icarito commented 7 years ago

It's the first time I notice this functionality,

I never thought of clearing the editor as a common enough function to require a toolbar button.

In the place of the user I'd be surprised. Undo is under a sub-palette, perhaps we could flatten the whole thing, or put eraser into edit sub-palette. Just a suggestion for discussion.

Thanks!

On 20/03/17 00:20, James Cameron wrote:

Ctrl+Z undo works to reverse any eraser button click. It is also in the scissors menu. Isn't that discoverable enough?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sugarlabs/Pippy/issues/44#issuecomment-287680504, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMMSxGz71MOnWLJIaz6an3iZ4CfMcnfks5rngyMgaJpZM4MiCQs.

quozl commented 7 years ago

I'm used to it, and it has been there for more than three years, so chances are others are used to it and may have made teaching plans that mention it. So I'm unwilling to change it myself without some good reason. If there is room for bringing undo and redo into the main toolbar box, I'm in favour.

It is easy to clear the editor by other means; select all text and type.

icarito commented 7 years ago

I understand, thanks!

icarito commented 7 years ago

Actually, I'm making a JS version of this activity and need to decide whether to replicate this functionality. Looking at Turtle Blocks JS and Turtle Blocks GTK, the same icon clears the canvas not the program. This seems more logical to me. @walterbender what do you think, it should be one or the other, no?

icarito commented 7 years ago

Okay I figured out where this is coming from. Today I ran an old image with Sugar 0.79, including old Pippy. In older versions, python examples are featured on a sidebar to the left, and there is a run and erase button to the right.

My feeling is that Pippy was meant as a showcase of Python examples and it could be useful to "clear" the modified example.

Still, for continuity with Turtle, I propose that this button clears the canvas (if wanted we can add a trash bin for clearing the code area).

I will prepare a patch.

quozl commented 7 years ago

Thanks, that makes sense. Yes, old Pippy was a side bar of examples and the buttons were not in the top line toolbar.