Move pippy to top level directory

sugarlabs / Pippy

Pippy allows the student to examine, execute, and modify simple Python programs. In addition it is possible to write Python statements to play sounds, calculate expressions, or make simple text based interactive games.

GNU General Public License v2.0

11 stars 34 forks source link

Move pippy to top level directory #77

Closed chimosky closed 4 years ago

chimosky commented 4 years ago

Fixes #75.

@quozl kindly review.

quozl commented 4 years ago

Can you tell me why you move library/pippy to pippy?

Will you also do this for other activities that contain library/pippy?

chimosky commented 4 years ago

I moved it because I didn't see a need for having it in library/ as the other files in library/ were no longer needed. I don't plan on doing this for other activities containing library/pippy except I have a reason to.

quozl commented 4 years ago

I think the move is not justified, and will make git blame and git bisect more difficult. I agree the Box2D directories you removed are not needed.

chimosky commented 4 years ago

Change made, kindly review.

quozl commented 4 years ago

Thanks. Tested the Graphics Physics example.

[ ] there is an unrelated change included in the commit without explanation; it should be in a separate commit.

chimosky commented 4 years ago

The change was put in the commit message.

quozl commented 4 years ago

Yes, I know. So what is the explanation for the unrelated change being included in the commit? Is there some relationship between the changes that I don't understand yet? I can't see any relationship.

chimosky commented 4 years ago

@quozl changes made, kindly review.