sugarlabs / aslo-v3

Upcoming Software Center for SugarLabs
2 stars 3 forks source link

Fix package build failures #15

Closed jatindhankhar closed 5 years ago

jatindhankhar commented 5 years ago

Aslov3-devel was failing while creating packages due to changes in the [ underlying wrappers of render_markdown of PyGithub] (https://github.com/PyGithub/PyGithub/blob/master/github/MainClass.py#L571) (I suspect) in the upstream, which was causing folllowing errors in build phase

Traceback (most recent call last):
05:08:54 worker.1 |   File "/srv/www/aslo3-devel/env/lib/python3.5/site-packages/celery/app/trace.py", line 382, in trace_task
05:08:54 worker.1 |     R = retval = fun(*args, **kwargs)
05:08:54 worker.1 |   File "/srv/www/aslo3-devel/aslo/celery_app.py", line 16, in __call__
05:08:54 worker.1 |     return TaskBase.__call__(self, *args, **kwargs)
05:08:54 worker.1 |   File "/srv/www/aslo3-devel/env/lib/python3.5/site-packages/celery/app/trace.py", line 641, in __protected_call__
05:08:54 worker.1 |     return self.run(*args, **kwargs)
05:08:54 worker.1 |   File "/srv/www/aslo3-devel/aslo/api/tasks.py", line 10, in release_process
05:08:54 worker.1 |     handle_release(gh_json)
05:08:54 worker.1 |   File "/srv/www/aslo3-devel/aslo/api/release.py", line 345, in handle_release
05:08:54 worker.1 |     gh_json['release']['body']
05:08:54 worker.1 |   File "/srv/www/aslo3-devel/aslo/api/gh.py", line 47, in render_markdown
05:08:54 worker.1 |     return g.render_markdown(message).decode()
05:08:54 worker.1 | AttributeError: 'str' object has no attribute 'decode'

Removing the redudant decode fixed it

jatindhankhar commented 5 years ago

cc @scanterog
Can someone merge this ?

jatindhankhar commented 5 years ago

@quozl

quozl commented 5 years ago

Thanks for asking, but I won't merge it, as I'm not focusing on aslo-v3, instead focusing on aslo-v1. Added you as collaborator.