search

sugarlabs / aslo-v4

A simple app store for sugarlabs
https://v4.activities.sugarlabs.org
GNU Affero General Public License v3.0
7 stars 12 forks source link

Reformatting navigation bar on ALSO v4 #74

Closed Shreyas-SAS closed 2 years ago

Shreyas-SAS commented 2 years ago

Taking reference from discussion on issue #71

I propose to make the following changes.

  1. shifting logo inside navigation bar.
  2. Linking logo to home page when clicked (bring it back to home page or else refresh on home page).
  3. removal of home button in navigation bar since its just a repetition of the logo functionality.
  4. moving search bar inside the navigation bar.
  5. changing position of theme selector to the right side corner.
Shreyas-SAS commented 2 years ago

@srevinsaju @quozl can you please have a look at the issue and assign me the issue.

quozl commented 2 years ago

We do not assign issues. We also don't create issues for things that we are going to fix ourselves. Issues are usually created for things we are not going to fix, or by people who don't have any plan to fix them. So an issue that you plan to fix is a bit unusual. I suggest opening a pull request instead.

Shreyas-SAS commented 2 years ago

We do not assign issues. We also don't create issues for things that we are going to fix ourselves. Issues are usually created for things we are not going to fix, or by people who don't have any plan to fix them. So an issue that you plan to fix is a bit unusual. I suggest opening a pull request instead.

oh ok. in sugarizer we usually created an issue to tell others what we are going to work on so that they could also suggest changes as well as counter the change,

many times it has happened in sugarizer that whenever one creates an issue, some other person may express his view on the issue and both parties come to an agreement of not going forward with the issue, it is a great practice I feel that should also be included on other sugar repositories.

You can see an example here of why issue creation before working could be really useful: issue on sugarizer

srevinsaju commented 2 years ago

Apparently aslo-v4 is a low traffic repository, and if any other person would like to come up with an alternative implementation, we tend to review both of them and get the best approach merged to main. Discussions are still open on issues.

Shreyas-SAS commented 2 years ago

Apparently aslo-v4 is a low traffic repository, and if any other person would like to come up with an alternative implementation, we tend to review both of them and get the best approach merged to main. Discussions are still open on issues.

okay, I will work on both the issues and send in a PR tonight, Still if you allow I would love to put a PR on specific issues rather than an unlinked PR. creating extra issues don't cost anything so I feel there might be no problem.

I will also create the issues for other suggestions open to community in case someone wants to contribute to it as I will be a little busy with my exams the next 2-3 weeks.

quozl commented 2 years ago

Closing as duplicate of https://github.com/sugarlabs/aslo-v4/issues/71