search

sugarlabs / aslo

https://activities.sugarlabs.org
Other
3 stars 3 forks source link

license field in activity.info not reporting errors #18

Open walterbender opened 6 years ago

walterbender commented 6 years ago

Related to #17 is a problem with the license check. Some common variations in specifying a license don't parse properly and through an error during upload that is not specific to the problem.

I don't recall the exact details, but GPLv3 worked and GPLv3+ did not? Or maybe it was GPL-3.0+ did not work? In any case either the parse should be more forgiving or the error message more specific.

quozl commented 6 years ago

Reproduced with Clock activity on 18th January; reviewed the ASLO source to find the critical code section, then changed change to semicolon as separator, see https://github.com/sugarlabs/clock-activity/commit/a805922302554cfd562085c990b91b834d06e45f and Wiki edit.

quozl commented 6 years ago