sugarlabs / browse-activity

Sugar activity to browse the internet; WebKit on GTK on Sugar Toolkit
GNU General Public License v2.0
8 stars 44 forks source link

Merge webkit2 branch #34

Closed davelab6 closed 8 years ago

davelab6 commented 8 years ago

What is needed for merging the webkit2 branch?

samdroid-apps commented 8 years ago

A few things. I'll keep a list here:

Debian bug #802380 has a link that reproduces a "WebKit has crashed"
dialog on Browse-158, for which I've attached a screenshot.

http://www.reuters.com/article/2015/10/18/us-new-york-flightcenter-idUSKCN0SC14B20151018

This was with 2.12.0, and it is probably a WebKit problem rather than
a Browse problem, but it does expose some Browse problems in handling
a WebKit crash ...

- the cursor keeps spinning,

- the home button doesn't work any more,

- the stop loading button doesn't work either,

- no evidence of the crash in the Browse logs.

The activity stop button worked fine.
The drag to new tab button works well.  Feedback would be nice; the
cursor doesn't indicate drag in progress.

There's a keep error if an old Browse journal object is used

Can the default font size be increased slightly?  In a side-by-side
test, between Browse-157.3 and Browse-158, the size has reduced
slightly.  Let me know if you want screenshots.

Basically, then it will be good for a release. I'll probably call it v200, just so it is easy to differentiate the releases of webkit1 (>200) and webkit2 (200s).

samdroid-apps commented 8 years ago

Done.