Add GSetting boolean to resolve conflict when 'Save-As' enabled

sugarlabs / browse-activity

Sugar activity to browse the internet; WebKit on GTK on Sugar Toolkit

GNU General Public License v2.0

8 stars 44 forks source link

Add GSetting boolean to resolve conflict when 'Save-As' enabled #49

Closed iamutkarshtiwari closed 7 years ago

iamutkarshtiwari commented 7 years ago

Added a boolean value to check if Save-As feature is enabled to prevent Browse from overwriting jobject's metadata-title provided by the user via Save-As alert box

iamutkarshtiwari commented 7 years ago

Here is the checklist status-

[x] wrap the Gio.Settings call to handle exception, which will occur if Browse is run on a version of Sugar before 0.112,
[x] check the setting during write_file rather than save it at startup.
[x] reference the new feature page in the commit description.

@quozl Please review

quozl commented 7 years ago

Thanks. Holding off on merge until https://github.com/sugarlabs/sugar-toolkit-gtk3/pull/327 is ready.

quozl commented 7 years ago

Rebased and merged as 38bdad4630254ade64dfb3b192f1ad2991b54fc5.