Enhance browser homepage

sugarlabs / browse-activity

Sugar activity to browse the internet; WebKit on GTK on Sugar Toolkit

GNU General Public License v2.0

8 stars 44 forks source link

Enhance browser homepage #88

Closed samswag closed 5 years ago

samswag commented 5 years ago

Fixed issue #87

samswag commented 5 years ago

@walterbender @quozl please review.

quozl commented 5 years ago

Thanks. Reviewed. Travelling right now, but I'll test on Tuesday.

quozl commented 5 years ago

Thanks. Tested. Comments;

[ ] the Sugar Labs logo is distorted (aspect ratio has changed, it is taller than it was),
[ ] the search entry border looks strange (dotted, misaligned with button),
[ ] the search text is not padded equally within the search entry, and;
[ ] the button is not the right size for Sugar buttons; it should be the same height as a cell in style, like the menu bar.

screenshot_ubb_2019-02-08_20 03 27

samswag commented 5 years ago

Thanks for the review I will investigate and send a fix.

quozl commented 5 years ago

Any news?

Also, Fedora Rawhide caused a bug 1668504 that fails to render the page because a change to freedesktop.org shared mime info package interacted with a WebKit behaviour. A workaround is to simplify the DOCTYPE in the file. So can you please advise what DOCTYPE to use, and if anything else needs to change in the file in order for it to be an HTML5 compliant web page?

samswag commented 5 years ago

Hi @quozl Yes, I was away from my keyboard for days now. I will look into this PR this week and make any modifications.

As per what type of Doctype to use. The one I proposed in this PR is the best one to use. See Discussion on stack overflow

quozl commented 5 years ago

Thanks, pushed the DOCTYPE change as 3d1e75b62feadf8fddff0baccf43dec9eb402884 for use as a bug fix.

samswag commented 5 years ago

I was away from my computer for days now. But I am back.

Thanks. Tested. Comments;

[ ] the Sugar Labs logo is distorted (aspect ratio has changed, it is taller than it was), Where was this tested? I am testing with Fedora 28 with a resolution if 1280 x 800

[ ] the search entry border looks strange (dotted, misaligned with button), That was a result of the autofocus to get the user ready to type in without clicking.

[ ] the search text is not padded equally within the search entry, and; I will make the adjustment

[ ] the button is not the right size for Sugar buttons; it should be the same height as a cell in style, like the menu bar.

I am not sure if I understand this part.

quozl commented 5 years ago

I'm not sure which part you mean.

samswag commented 5 years ago

The Sugar Button part.

On Thu, Feb 28, 2019, 1:31 AM James Cameron notifications@github.com wrote:

I'm not sure which part you mean.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sugarlabs/browse-activity/pull/88#issuecomment-468087230, or mute the thread https://github.com/notifications/unsubscribe-auth/AFxLWbS9rcxaiuyf4tZ1U91Qd0rVOfVQks5vRyNbgaJpZM4afwSJ .

quozl commented 5 years ago

Please review https://wiki.sugarlabs.org/go/Human_Interface_Guidelines/The_Sugar_Interface/Layout_Guidelines and see if that helps? The toolbar buttons are all one grid cell, so that's the best size for a button.

samswag commented 5 years ago

Thanks I will review.

On Thu, Feb 28, 2019, 1:36 AM James Cameron notifications@github.com wrote:

Please review https://wiki.sugarlabs.org/go/Human_Interface_Guidelines/The_Sugar_Interface/Layout_Guidelines and see if that helps?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sugarlabs/browse-activity/pull/88#issuecomment-468088362, or mute the thread https://github.com/notifications/unsubscribe-auth/AFxLWX6TEXqAe_SIfWE2C8FceQuT0a9Aks5vRyScgaJpZM4afwSJ .

rhl-bthr commented 5 years ago

Stale