search

sugarlabs / browse-activity

Sugar activity to browse the internet; WebKit on GTK on Sugar Toolkit
GNU General Public License v2.0
8 stars 44 forks source link

Change search engine to DuckDuckGo #92

Closed ghost closed 5 years ago

ghost commented 5 years ago

This pull request will change the Browse activity's default search engine to DuckDuckGo, as happened previously in the GNOME Web browser. DuckDuckGo's data privacy principles are in line with those of the free software movement.

The language matching code will be removed, as, according to https://duckduckgo.com/params, DuckDuckGo's search language codes are not POSIX-compliant.

quozl commented 5 years ago

Thanks. I'm not in favour of this change, but I'll first wait for others to comment before deciding what to do about it.

aperezbios commented 5 years ago

Nor I, because it completely ignores the installed base, and pays no mind to what our users actually want. These sorts of contributions are really not helpful, and can inadvertantly spark rifts within the community. If your underlying rationale for the change was, instead, "the majority of Sugar users said they want this" then I could likely be convinced this was a worthwhile change.

I recommmend that you re-factor this change such that you make the search engine runtime-configurable, and then document what needs to be done to set this parameter. This seems a reasonable compromise.

ghost commented 5 years ago

I most dearly apologize. I suggest that this pull request be closed, and will open a new one shortly. (At the moment, I cannot close it myself, being away from home.)

-----Original Message----- From: reply@reply.github.com Sent: Mon, 03 Jun 2019 09:52:12 -0700 To: 3603060030@txt.att.net Subject: Re: [sugarlabs/browse-activity] Change search engine to DuckDuck

Nor I, because it completely ignores the installed base, and pays no mind to what our users actually want. These sorts of contributions are really not helpful, and can inadvertan

================================================================== This mobile text message is brought to you by AT&T

ghost commented 5 years ago

I am now connected to a Wi-Fi hotspot. Closing #92 and deleting fork rcunning01/browse-activity.

quozl commented 5 years ago

Thanks for trying, and I look forward to your next. Firefox's search widget may be an interesting model to use; it pops up a window below the search box, offering what service to search with. If the input is finished with enter the default used. Or the input can be finished by clicking one of the service buttons.