search

sugarlabs / chat

The Sugar chat activity
GNU General Public License v2.0
5 stars 25 forks source link

Use dbus directly instead of telepathy channel and Connection #21

Closed Aniket21mathur closed 5 years ago

Aniket21mathur commented 5 years ago

Tested one to one sugar connection with https://github.com/sugarlabs/sugar/pull/837/commits/3dcd97a1d295b1f5602f87fa00b71500ebee3dd9 and https://github.com/sugarlabs/sugar-toolkit-gtk3/pull/412/commits/1233eec3d163f8ca86df675bebcba04272b93b5d.

Aniket21mathur commented 5 years ago

No need of these changes after https://github.com/sugarlabs/sugar-toolkit-gtk3/pull/412/commits/d7fe5ae3fb885979bc6e3bd070f7316862b011a6.

quozl commented 5 years ago

We are using TelepathyGLib operations as consequence of https://github.com/sugarlabs/chat/commit/613ea700bfd353b0ae6e2b02b5902de530bb5d38, and TextChannelWrapper is derived from CollabWrapper. I'm not sure if the mixing of API will be a problem. While not critical to fix, there's an opportunity to do so. https://github.com/sugarlabs/chat/issues/22.