search

sugarlabs / clock-activity

A nice clock for the Sugar learning environment
Other
0 stars 6 forks source link

Remove the Gstreamer dependency #10

Closed cvgarciarea closed 7 years ago

cvgarciarea commented 7 years ago

I removed the Gstreamer dependency, and removed "_HAS_SPEECH_MANAGER" on speaker.py (it isn't necesary now).

GCI Task: https://codein.withgoogle.com/dashboard/task-instances/6594765753679872/

quozl commented 7 years ago

You have also removed a useful feature; the activity will now fail to start on older versions of the toolkit that do not have SpeechManager.

It is possible to remove the GStreamer dependency without removing compatibility.

cvgarciarea commented 7 years ago

You're right, now it's okay?

quozl commented 7 years ago

Thanks, is good.