search

sugarlabs / clock-activity

A nice clock for the Sugar learning environment
Other
0 stars 6 forks source link

Fixed #14: Simplify time translation #15

Closed EmilyOng closed 6 years ago

EmilyOng commented 6 years ago

Hello, I have simplified the translation according to the remarks in issue #14 !

screen shot 2017-12-13 at 9 05 33 pm

I have simplified the clock translation by:

    time(12, 0) => twelve noon |
    time(0, 0) => midnight |
    time(h, 0) => hour(h) o'clock am_pm(h) |
    time(h, m) [m < 10] => hour(h) o' min(m) am_pm(h) |
    time(h, m) [m >= 10] => hour(h) min(m) am_pm(h) |

Changing the output of time(12, 0) to twelve noon instead of hour(12),
because for the sake of simplification, I have removed 'noon', 'midnight'
and 'quarter' from the list of strings (Same goes for midnight)

I actually though that if we indicated the time as "eleven one" or "ten
two", it will be rather weird. So I added a rule, where if the minute(m)
is less than 10, it will read "eleven o' one" instead. How is this?

In addition, I removed the "minutes" in the rules.

Please let me know how this is, thank you so much!

EmilyOng commented 6 years ago

@leonardcj @quozl @walterbender you might want to take a look at this after discussion in #11 :)

https://github.com/EmilyOng/clock-activity/wiki

EmilyOng commented 6 years ago

https://github.com/sugarlabs/clock-activity/issues/14