Closed EmilyOng closed 6 years ago
Thanks for the comments!
I have done that for the individual minutes and hours in the recent commit.
Improved formatting to eg.
%(hour)s % {'hour': ...}
Left out markup wrapper that targets the entire string outside of gettext and only included relevant markup for colors
Left out all markup outside of gettext and only used formatters within gettext
Included for all gettext references that I have added
Removed all instances of timewriter and the relevant files
One last thing: it would be good to avoid lines longer than 80 characters throughout.
@EmilyOng @walterbender Looking forward to a much more easily localized Clock, thanks so much for the improvements in internationalization (i18n). It is so important for developers to learn about making their code easier to translate (L10n) into many languages by developing their i18n strategy along with the code.
with regards to issue #14, i have reduced the complexity of how the markup is being rendered in the translation files by using string formatters, as suggested by @walterbender. i have also made the written/spoken time more direct, eg. one fourty-five PM, midnight, noon, one o'clock AM