sugarlabs / convert

Sugar units conversion activity
GNU General Public License v3.0
0 stars 6 forks source link

Save last used dimension and units in journal object #13

Closed quozl closed 5 years ago

quozl commented 6 years ago

Reproducer: start, change dimension and units, stop, restart from journal entry.

Expected: dimension and units preserved.

Observed: dimension and units are reset to Length - Cables.

At the same time, add a reset button to restore dimension and units to defaults.

Aniket21mathur commented 5 years ago

I am sorry I am not able to understand what exactly do you mean by journal entry and journal object? Thanks!

quozl commented 5 years ago

https://help.sugarlabs.org/en/journal.html should help to explain. Every Sugar activity creates a Journal Entry. Internally, a Journal Entry is implemented as a Journal Object in Python. Look at the activity API sources in the toolkit.

Aniket21mathur commented 5 years ago

@quozl I am sorry but still I am not able to understand what's the difference between Journal entry and user's activity instance data directory.I don't know much about journal entry but as per my knowledge of user's activity instance data directory won't it be better to save this dimensions and units at user's activity instance data directory.I worked on it and made a pull request I request you to once review it and decide :smile: .Thanks!

quozl commented 5 years ago

@Aniket21mathur, the difference is profound and yet subtle.

I suggest you read one of the guides to writing Sugar activities.

kushagra98 commented 5 years ago

Is this issue still open?