sugarlabs / convert

Sugar units conversion activity
GNU General Public License v3.0
0 stars 6 forks source link

Value entry does not need spin buttons #14

Closed quozl closed 5 years ago

quozl commented 6 years ago

To the left of the Convert button is a value entry widget.

On the GTK+ 2 version, this was rendered with spin buttons; up and down arrows vertically aligned.

On the GTK+ 3 version, this is rendered with spin buttons; - and + horizontally aligned.

However, spin buttons are not needed, are a distraction, and so a plain unadorned text entry can be used instead.

chimosky commented 6 years ago

However, spin buttons are not needed, are a distraction, and so a plain unadorned text entry can be used instead.

Respectfully disagree, the spin buttons are the only way - currently - to increase the value of the unit being converted from and it can contain any value up to 10000000000 . When you say plain unadorned text, what do you mean?.

quozl commented 6 years ago

That is not what I see; I can increase the value by clicking on the number, and typing a new number. That's quicker and more accurate than pressing the spin buttons. I don't think this entry widget needs the spin buttons.

chimosky commented 6 years ago

I now understand.