search

sugarlabs / convert

Sugar units conversion activity
GNU General Public License v3.0
0 stars 6 forks source link

Convert button should be automatic #16

Closed quozl closed 5 years ago

quozl commented 6 years ago

Reproducer: enter a value for conversion, press convert, enter a different value.

Problem: result displayed is inconsistent with entered value.

Proposed solution: remove the convert button and do the conversion on each change to the value.

quozl commented 6 years ago

Also, just pressing enter after typing a number doesn't do convert, as of 7bb29e4f670b2dae1dfdd645fe0c7c6b83c75049.

Aniket21mathur commented 5 years ago

@quozl convert button pressing is an event from the user that signals that the user has finished entering the value to be converted.How it can be automatic? There must be some event that should be triggered from user side to start conversion like some key press or clicking conversion button.Thanks!

quozl commented 5 years ago

Yes. It can be automatic by using the insert-text signal. Pressing enter will cause the activate signal.

quozl commented 5 years ago

@chimosky, please review this issue and pull request https://github.com/sugarlabs/convert/pull/22