sugarlabs / convert

Sugar units conversion activity
GNU General Public License v3.0
0 stars 6 forks source link

Add edit toolbar and buttons #18

Closed quozl closed 5 years ago

quozl commented 6 years ago

As of 7bb29e4f670b2dae1dfdd645fe0c7c6b83c75049 the result can be copied by selecting it and using a mouse drag or ctrl+c shortcut. A text clipping can be dragged from the frame into the input field. But there's no toolbar buttons.

Add an edit toolbar and buttons. See toolkit and other activities for an example edit toolbar and icons.

Aniket21mathur commented 5 years ago

Can you please provide me more details about what kind of toolbar you want and which buttons should be there.It would be of great help to me if you give example of an activity. Thanks a lot!

quozl commented 5 years ago

No, I'd prefer there be design input before I give my opinions. I'm not looking for slaves. :grinning: Please review each of the activities in our core set, we call them Fructose, and look particularly at the edit toolbars and buttons associated with text editing.

Hrishi1999 commented 5 years ago

I've implemented it but had a few doubts before I push my changes. Do we need a paste button? Should the paste button set the text of entry to converted value (this would change the meaning of the paste button)? Should the copy button copy the whole output or just the converted value?

quozl commented 5 years ago

Good point about paste. Copy alone would not be as useful. I withdraw the suggestion.