[W.I.P]Saving last used dimension and units

Aniket21mathur commented 5 years ago

Previously dimension and units are reset to Length - Cables.

Now saving the last used dimensions and units in user's activity instance data directory.

quozl commented 5 years ago

Thanks. Reviewed. Comments;

[ ] there's an API for that, please use sugar3.activity.get_activity_root() rather than the environment variable SUGAR_ACTIVITY_ROOT, because the directory may not exist. Please review other activity source code to see how it can be done, and my change to the documentation),
[ ] no need to set dir to '' first,
[ ] common code could be in separate function to return the configuration file name,
[ ] import ast is very rare in Sugar activities, please use JSON in the file,
[ ] format_Str is a mixed case name, and I wasn't able to understand why it is being used,
[ ] add more detail to your commit messages, see Making commits.

rhl-bthr commented 5 years ago

@Aniket21mathur ping

Aniket21mathur commented 5 years ago

@pro-panda I will make the changes in the pr soon. Thanks for reminding.

Aniket21mathur commented 5 years ago

I am not working on this currently. Anyone who wishes to continue, feel free to do so. :-)

sugarlabs / convert