Activity review comments

sugarlabs / convert

Sugar units conversion activity

GNU General Public License v3.0

0 stars 6 forks source link

Closed quozl closed 5 years ago

quozl commented 5 years ago

[x] starting the activity shows no units selected,
[x] switching between unit ranges using the toolbar doesn't select any default units,
[x] entering 9 shows 9.0 ~ -9.00000000001, it should be 9 ~ 9,
[x] there's no tooltip for the swap units button,
[x] swap of units changes to a different value with too many significant digits (e.g. select inches to millimetres, enter 1.0, click on swap, the entry box now contains 0.0393700787402 and the conversion 0.00155000310001)

nswarup14 commented 5 years ago

@quozl @chimosky What work is still left in this issue? I am currently reading up on the PR (#26) and to understand the work still left.

Thanks

quozl commented 5 years ago

Please test each and let me know what you observe.

quozl commented 5 years ago

I've tested each, as of 5ad65539e4eb6f2391d72481d1850bbc0c1464ec, and they are all fixed.

nswarup14 commented 5 years ago

The issue can be closed.

quozl commented 5 years ago

Thanks.