sugarlabs / convert

Sugar units conversion activity

GNU General Public License v3.0

0 stars 6 forks source link

Display conversion ratio between two units #31

Closed nswarup14 closed 5 years ago

nswarup14 commented 5 years ago

Fixes #27

Changes 1) activity.py

Updates 1) Add a Gtk.Label to show the conversion ratio between units, below entry widget.

Tested on Ubuntu 18.04 and Sugar v0.114

Hrishi1999 commented 5 years ago

Tested. Works as expected.

quozl commented 5 years ago

tmp

quozl commented 5 years ago

Conversion ratio display was merged in https://github.com/sugarlabs/convert/pull/30

nswarup14 commented 5 years ago

@quozl I did not understand why this branch was closed.

30 did not include the conversion ratio.

quozl commented 5 years ago

Oh, I see now. Thanks. Given that other pull requests have merged and another is due to merge soon, how do you propose to proceed?

nswarup14 commented 5 years ago

@quozl Thanks!

The PR of redesign has been merged and PR of preserving dimensions and units is due to merge soon. However, the latter PR would not affect this in anyway.

I would rebase the present commits on top of PR #30 and continue to work from there.

Would that be alright?

quozl commented 5 years ago

Thanks. Please rebase from the new master, and open a new pull request.

nswarup14 commented 5 years ago

@quozl Yes, I shall do so immediately. I had already rebased it till #30. I shall make a new PR soon.